mhilton commented on issue #10602:
URL: https://github.com/apache/datafusion/issues/10602#issuecomment-2126436509

   > I'm curious as to why we wouldn't want to just make date_bin timezone 
aware?
   
   I'm not sure that it's obvious how a time-zone aware date_bin would behave. 
For example On the day in october when many time zones repeat an hour would the 
two hours count into a single bin? What about if you had hour long bins that 
start 30 minutes into the hour? Given that the two hours are easily 
distinguishable the answer is probably not, and if you really want that 
behviour then stripping time zone information would be a reasonable way to get 
it.
   
   If we restricted timezone awareness intervals of unit days then that would 
be much more reasonable. We could make it so that date_bin understands the 
number of hours in any given day in a time zone and bins a time accordingly. 
Anyone needing a strict 24 hour binning could specify the interval in hour 
units.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to