berkaysynnada commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1611257842
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -258,6 +259,10 @@ impl CaseExpr {
}
}
+lazy_static! {
Review Comment:
`with_new_children()` of `CaseExpr` says that:
`// For physical CaseExpr, we do not allow modifying children size`.
That sentence tells me that we can also should not change the existence of
expressions. Can we just insert the new children into the Some() ones in the
element order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
