peter-toth commented on PR #10543: URL: https://github.com/apache/datafusion/pull/10543#issuecomment-2125641924
I've rebased the PR on the latest `main`. The first commit is exactly the same as the previous state of this PR was, the second commit changes `TreeNode:apply()` and `TreeNode:visit()` APIs to use references whose lifetime matches the root treenode's lifetime. The only `TreeNode` that was not compatible with this stricter APIs is `DynTreeNodes`. I had to change it and its implementations to return children as `Vec<&Arc<Self>>` (instead of `Vec<Arc<Self>>`). This PR doesn't change the `LogicalPlan::apply_with_subqueries()` and `LogicalPlan:visit_with_subqueries()` APIs. This is becaususe in `LogicalPlan::apply_expressions()` and `LogicalPlan::apply_subqueries()` we create temporary `Expr::eq`, `Expr::Column` and `LogicalPlan::Subquery` objects that are not compatible with the root treenode's lifetime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
