alamb opened a new pull request, #10643: URL: https://github.com/apache/datafusion/pull/10643
## Which issue does this PR close? Part of #10546 ## Rationale for this change While working on https://github.com/apache/datafusion/pull/10549 it was cumbersome to create a `ParquetExec` -- specifically there are a few fields on `ParquetExec::new` that must always be provided even though they are `Option`s and most of the rest of the options can be set via builder style APIs like `with_schema_adapter_factory` In addition, some fields like `schema_adapter_factory` can not be set by constructor but are instead set by builder function `with_schema_adapater_factor`. Thus it is confusing and imposes a cognitive load that the properties setting is inconsistent. ## What changes are included in this PR? 1. Remove all arguments except FileScanConfig from `ParquetExec::new` 2. Add builder style APIs 2. Improve documentation 2. Add examples ## Are these changes tested? Yes by existing CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? This is a user API change for anyone who creates ParquetExec's directly (as we do in InfluxDB IOx for example) There is also better documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
