andygrove opened a new issue, #468:
URL: https://github.com/apache/datafusion-comet/issues/468
### Describe the bug
In `CometExpressionSuite` we have two tests that are ignored for Spark 3.2
and 3.3.
```scala
test("cast timestamp and timestamp_ntz to string") {
// TODO: make the test pass for Spark 3.2 & 3.3
assume(isSpark34Plus)
```
```scala
test("cast timestamp and timestamp_ntz to long, date") {
// TODO: make the test pass for Spark 3.2 & 3.3
assume(isSpark34Plus)
```
Enabling these tests for 3.2 shows incorrect output:
```
== Results ==
!== Correct Answer - 2001 ==
== Spark Answer - 2001 ==
struct<tz_millis:string,ntz_millis:string,tz_micros:string,ntz_micros:string>
struct<tz_millis:string,ntz_millis:string,tz_micros:string,ntz_micros:string>
![1970-01-01 05:29:59.991,1970-01-01 05:29:59.991,1970-01-01
05:29:59.991,1970-01-01 05:29:59.991] [1970-01-01 05:29:59.991,1969-12-31
23:59:59.991,1970-01-01 05:29:59.991,1969-12-31 23:59:59.991]
```
```
== Results ==
!== Correct Answer - 10000 ==
== Spark Answer
- 10000 ==
struct<tz_millis:bigint,tz_micros:bigint,tz_millis_to_date:date,ntz_millis_to_date:date,tz_micros_to_date:date,ntz_micros_to_date:date>
struct<tz_millis:bigint,tz_micros:bigint,tz_millis_to_date:date,ntz_millis_to_date:date,tz_micros_to_date:date,ntz_micros_to_date:date>
![-1,-1,1970-01-01,1970-01-01,1970-01-01,1970-01-01]
[-1,-1,1970-01-01,1969-12-31,1970-01-01,1969-12-31]
```
We should fall back to Spark rather than produce the wrong results.
### Steps to reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
