alamb commented on code in PR #10268: URL: https://github.com/apache/datafusion/pull/10268#discussion_r1614530863
########## datafusion/sqllogictest/test_files/select.slt: ########## @@ -1473,7 +1473,7 @@ DROP TABLE t; # related to https://github.com/apache/datafusion/issues/8814 statement ok -create table t(x int, y int) as values (1,1), (2,2), (3,3), (0,0), (4,0); +create table t(x bigint, y bigint) as values (1,1), (2,2), (3,3), (0,0), (4,0); Review Comment: Could you please keep the existing test and add a new test that uses `bigint` so it is clearer what behavior is changing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
