goldmedal commented on code in PR #10661:
URL: https://github.com/apache/datafusion/pull/10661#discussion_r1614539989
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -2893,21 +2893,21 @@ mod tests {
for function in all_default_functions() {
let udf = new_state.register_udf(function).unwrap();
if let Some(udf) = udf {
- assert!(false, "Function {} already registered", udf.name());
+ unreachable!("Function {} already registered", udf.name());
}
}
for function in all_default_array_functions() {
let udf = new_state.register_udf(function).unwrap();
if let Some(udf) = udf {
- assert!(false, "Function {} already registered", udf.name());
+ unreachable!("Function {} already registered", udf.name());
}
}
for function in all_default_aggregate_functions() {
let udaf = new_state.register_udaf(function).unwrap();
if let Some(udaf) = udaf {
- assert!(false, "Function {} already registered", udaf.name());
+ unreachable!("Function {} already registered", udaf.name());
Review Comment:
Clippy suggests that I use `panic` or `unreachable` instead of `assert`. I'm
not sure which one is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
