andygrove commented on code in PR #472:
URL: https://github.com/apache/datafusion-comet/pull/472#discussion_r1615306091
##########
dev/scalastyle-config.xml:
##########
@@ -242,7 +242,7 @@ This file is divided into 3 sections:
<parameter name="groups">java,scala,org,apache,3rdParty,comet</parameter>
<parameter name="group.java">javax?\..*</parameter>
<parameter name="group.scala">scala\..*</parameter>
- <parameter name="group.org">org\.(?!apache\.comet).*</parameter>
Review Comment:
We should exclude all apache packages from the `org` group, not just comet.
We have a separate rule below for excluding comet from the apache group.
Without this change it was not possible to satisfy both scalastyle and
scalafix at the same time as they wanted different import orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
