jonahgao commented on code in PR #10683:
URL: https://github.com/apache/datafusion/pull/10683#discussion_r1615419322
##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -1411,15 +1411,15 @@ fn to_substrait_type(dt: &DataType, nullable: bool) ->
Result<substrait::proto::
parameter:
Some(parameter::Parameter::DataType(substrait::proto::Type {
kind: Some(r#type::Kind::I32(r#type::I32 {
type_variation_reference: DEFAULT_TYPE_REF,
- nullability: default_nullability,
+ nullability: r#type::Nullability::Unspecified as i32,
Review Comment:
We are not using the nullability of the parameter on the consumer side, so I
temporarily change it to `Unspecified`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
