Blizzara commented on code in PR #10646:
URL: https://github.com/apache/datafusion/pull/10646#discussion_r1616129968
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1160,6 +1162,24 @@ pub(crate) fn from_substrait_type(dt:
&substrait::proto::Type) -> Result<DataTyp
"Unsupported Substrait type variation {v} of type
{s_kind:?}"
),
},
+ r#type::Kind::UserDefined(u) => {
+ match u.type_reference {
+ INTERVAL_YEAR_MONTH_TYPE_REF => {
Review Comment:
I may be totally wrong, but are you sure this is how `type_reference` is
supposed to work? I'd kind of expect the type_reference to map to an extension
/ MappingType::ExtensionType, kinda like
[function_reference](https://github.com/apache/datafusion/blob/2e6beb434d45693bc8c7ba636b0407c26c04fc37/datafusion/substrait/src/logical_plan/consumer.rs#L747).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
