alamb commented on code in PR #10646:
URL: https://github.com/apache/datafusion/pull/10646#discussion_r1617070330
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1160,6 +1162,24 @@ pub(crate) fn from_substrait_type(dt:
&substrait::proto::Type) -> Result<DataTyp
"Unsupported Substrait type variation {v} of type
{s_kind:?}"
),
},
+ r#type::Kind::UserDefined(u) => {
+ match u.type_reference {
+ INTERVAL_YEAR_MONTH_TYPE_REF => {
Review Comment:
I am not at all sure how this is supposed to work -- when I was reviewing
this PR I think I concluded it followed the existing patterns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
