sunchao commented on code in PR #476: URL: https://github.com/apache/datafusion-comet/pull/476#discussion_r1616187365
########## common/src/main/scala/org/apache/arrow/c/CometSchemaImporter.scala: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.arrow.c + +import org.apache.arrow.memory.BufferAllocator +import org.apache.arrow.vector.types.pojo.Field + +/** + * This is a simple wrapper around SchemaImporter to make it accessible from Java Arrow. + */ +class CometSchemaImporter(allocator: BufferAllocator) { Review Comment: should we implement this in Java? ########## common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala: ########## @@ -264,4 +265,24 @@ object Utils { throw new SparkException(s"Unsupported Arrow Vector for $reason: ${valueVector.getClass}") } } + + /** + * Imports data from ArrowArray/ArrowSchema into a FieldVector. This is basically the same as + * Java Arrow `Data.importVector`. `Data.importVector` initiates `SchemaImporter` internally + * which is used to fill dictionary ids for dictionary encoded vectors. Every call to + * `importVector` will begin with dictionary ids starting from 0. So, separate calls to + * `importVector` will overwrite dictionary ids. To avoid this, we need to use the same + * `SchemaImporter` instance for all calls to `importVector`. + */ + def importVector( Review Comment: ditto: may be it's better to put this in a separate class in Java other than spark.sql.comet.util? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
