duongcongtoai commented on code in PR #10689:
URL: https://github.com/apache/datafusion/pull/10689#discussion_r1616360398
##########
datafusion/physical-plan/src/unnest.rs:
##########
@@ -515,16 +515,10 @@ fn unnest_list_arrays(
})
.collect::<Result<Vec<_>>>()?;
- // If there is only one list column to unnest and it doesn't contain any
NULL lists,
- // we can return the values array directly without any copying.
- if typed_arrays.len() == 1 && typed_arrays[0].null_count() == 0 {
- Ok(vec![typed_arrays[0].values().clone()])
Review Comment:
this will return the underlying low level array, which include the row
indices filtered out by limit/offset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
