waynexia commented on code in PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#discussion_r1618334298
##########
datafusion/physical-plan/src/work_table.rs:
##########
@@ -169,7 +169,7 @@ impl ExecutionPlan for WorkTableExec {
&self.cache
}
- fn children(&self) -> Vec<Arc<dyn ExecutionPlan>> {
+ fn children(&self) -> Vec<&Arc<dyn ExecutionPlan>> {
Review Comment:
I've tried to return `&[Arc<dyn ExecutionPlan>]` and it fails unsurprisingly
-- unless we stores all children in a vector like `Union`:
```rust
fn children(&self) -> &[Arc<dyn ExecutionPlan>] {
self.inputs.as_slice()
}
```
Otherwise we cannot return a temporary slice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
