vaibhawvipul commented on code in PR #500:
URL: https://github.com/apache/datafusion-comet/pull/500#discussion_r1624694390
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1474,15 +1481,14 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
None
}
- case Abs(child, _) =>
+ case Abs(child, failOnErr) =>
Review Comment:
since we are already using failOnErr, can we simply use this boolean instead
of evalmode struct? what are you thoughts?
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -850,6 +850,34 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("abs Overflow ansi mode") {
+ val data: Seq[(Int, Int)] = Seq((Int.MaxValue, Int.MinValue))
Review Comment:
Can we have tests for all numerical values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
