planga82 commented on code in PR #500:
URL: https://github.com/apache/datafusion-comet/pull/500#discussion_r1624851281
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1474,15 +1481,14 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
None
}
- case Abs(child, _) =>
+ case Abs(child, failOnErr) =>
Review Comment:
Hi, thanks for your review! The intention why it is done this way is that in
the Rust code the ansi mode is always treated the same way whether the
expression supports the three ansi modes or only two. If not, we have to do a
different treatment for both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
