alamb commented on PR #10560: URL: https://github.com/apache/datafusion/pull/10560#issuecomment-2156133115
> > I have some ideas about additional comments / documentation that I would be happy to help add > > Sure! Thank you for your patience @jayzhan211 -- I just pushed a bunch of docs and tests (and a small API refinement): 1. Consolidated the example into the expr_api.rs examples 2. Simplified the api for `filter` from `filter(Box<Expr>)` to just `filter(Expr)` 3. Added documentation and examples to the trait 4. Added tests 5. Checked for SortExprs in `order_by` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
