Lordworms commented on PR #10842: URL: https://github.com/apache/datafusion/pull/10842#issuecomment-2156797223
another problem here is that the json file seems to do projection after aggregation <img width="867" alt="image" src="https://github.com/apache/datafusion/assets/48054792/42213070-9f6d-4293-a0c1-5e3f54312391";> so in the actual logical plan generated from this proto, we do aggregate after projection but in datafusion, the actual tpch plan looks like this <img width="1003" alt="image" src="https://github.com/apache/datafusion/assets/48054792/4e65da7e-b10d-4b6f-9835-c1bcca2344d3";> don't know which one is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
