appletreeisyellow commented on code in PR #10651:
URL: https://github.com/apache/datafusion/pull/10651#discussion_r1633879306
##########
datafusion/physical-expr/src/aggregate/build_in.rs:
##########
@@ -103,16 +104,9 @@ pub fn create_aggregate_expr(
name,
data_type,
)),
- (AggregateFunction::Sum, false) => Arc::new(expressions::Sum::new(
- input_phy_exprs[0].clone(),
- name,
- input_phy_types[0].clone(),
- )),
- (AggregateFunction::Sum, true) =>
Arc::new(expressions::DistinctSum::new(
- vec![input_phy_exprs[0].clone()],
- name,
- data_type,
- )),
+ (AggregateFunction::Sum, _) => {
+ return internal_err!("Builtin Sum will be removed");
+ }
Review Comment:
Hi @jayzhan211! I saw @alamb already asked the same question
[here](https://github.com/apache/datafusion/pull/10651#issuecomment-2145952988)
last week. I'd like to follow-up and check if you have any plans to remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
