jayzhan211 commented on code in PR #10651:
URL: https://github.com/apache/datafusion/pull/10651#discussion_r1634006543
##########
datafusion/physical-expr/src/aggregate/build_in.rs:
##########
@@ -103,16 +104,9 @@ pub fn create_aggregate_expr(
name,
data_type,
)),
- (AggregateFunction::Sum, false) => Arc::new(expressions::Sum::new(
- input_phy_exprs[0].clone(),
- name,
- input_phy_types[0].clone(),
- )),
- (AggregateFunction::Sum, true) =>
Arc::new(expressions::DistinctSum::new(
- vec![input_phy_exprs[0].clone()],
- name,
- data_type,
- )),
+ (AggregateFunction::Sum, _) => {
+ return internal_err!("Builtin Sum will be removed");
+ }
Review Comment:
@appletreeisyellow You can checkout main branch it should be removed in
https://github.com/apache/datafusion/pull/10831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
