comphead commented on code in PR #10892:
URL: https://github.com/apache/datafusion/pull/10892#discussion_r1637256082
##########
datafusion/sqllogictest/test_files/sort_merge_join.slt:
##########
@@ -84,7 +84,6 @@ SELECT * FROM t1 LEFT JOIN t2 ON t1.a = t2.a AND t2.b * 50 <=
t1.b
Alice 100 Alice 1
Alice 100 Alice 2
Alice 50 Alice 1
-Alice 50 NULL NULL
Review Comment:
Agree, just checked in DuckDB
```
D CREATE TABLE t1(a text, b int); insert into t1 VALUES ('Alice', 50),
('Alice', 100), ('Bob', 1);
D CREATE TABLE t2(a text, b int);
D insert into t2 VALUES ('Alice', 2), ('Alice', 1);
D SELECT * FROM t1 LEFT JOIN t2 ON t1.a = t2.a AND t2.b * 50 <= t1.b
>
> ;
┌─────────┬───────┬─────────┬───────┐
│ a │ b │ a │ b │
│ varchar │ int32 │ varchar │ int32 │
├─────────┼───────┼─────────┼───────┤
│ Alice │ 50 │ Alice │ 1 │
│ Alice │ 100 │ Alice │ 1 │
│ Alice │ 100 │ Alice │ 2 │
│ Bob │ 1 │ │ │
└─────────┴───────┴─────────┴───────┘
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
