comphead commented on code in PR #562:
URL: https://github.com/apache/datafusion-comet/pull/562#discussion_r1637313949
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -158,28 +158,30 @@ class CometSparkSessionExtensions
// data source V1
case scanExec @ FileSourceScanExec(
HadoopFsRelation(_, partitionSchema, _, _, _:
ParquetFileFormat, _),
- _: Seq[AttributeReference],
+ attrs: Seq[_],
Review Comment:
I'm not sure if its needed tbh, can be `FileSourceScanExec` be constructed
in some other way? I'd say we can just replace it with underscore like other
params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
