tmi opened a new pull request, #10899:
URL: https://github.com/apache/datafusion/pull/10899

   ## Which issue does this PR close?
   
   Closes https://github.com/apache/datafusion/issues/6133, or at least, 
improves the situation noticeably.
   
   ## Rationale for this change
   
   Using too big number (to fit to int32) causes a panic and crash, which is 
bad. We change it to only return an execution error.
   
   I don't make the planning-phase mitigation, as proposed in 
https://github.com/apache/datafusion/issues/6133#issuecomment-1555164645, as 
that's a bigger thing. This PR is minor enough that it doesn't any hassle when 
a proper solution is attempted.
   
   ## What changes are included in this PR?
   
   A minor change of trying to cast the argument, and returning error in case 
it fails.
   
   ## Are these changes tested?
   
   Yes, new test case has been added with the exact scenario.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to