alamb commented on code in PR #10956:
URL: https://github.com/apache/datafusion/pull/10956#discussion_r1643248029


##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -859,6 +878,35 @@ impl Unparser<'_> {
         }
     }
 
+    fn process_interval_nanosecond(nano: i64) -> String {

Review Comment:
   There seems to be similar code already in 
https://github.com/apache/arrow-rs/blob/72467c670f8c38130e4743347407f1a542e59e0c/arrow-cast/src/display.rs#L600-L649
   
   I think we could potentially use it via
   
   https://docs.rs/arrow/latest/arrow/util/display/fn.array_value_to_string.html
   
   After first converting ScalarValue to a one value array: 
https://docs.rs/datafusion/latest/datafusion/common/enum.ScalarValue.html#method.to_array



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to