alamb commented on code in PR #11049:
URL: https://github.com/apache/datafusion/pull/11049#discussion_r1650079670
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -317,16 +317,27 @@ fn rename_expressions(
.into_iter()
Review Comment:
As `rename_expressions` is getting more feature-full perhaps we can add some
doc comments explaining what it is doing (I think it is basically renaming
expressions from substrait to match DataFusion's expectations?)
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -846,6 +861,24 @@ pub async fn from_substrait_rel(
}
}
+fn requalify_sides_if_needed(
Review Comment:
Perhaps you could add some of the excellent context from this PR's
description as docstrings here to help future readers understand what is going
on
This is not strictly necessary as I think the comments in the function
explain it, but docstrings would still be nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
