viirya commented on code in PR #11232:
URL: https://github.com/apache/datafusion/pull/11232#discussion_r1664825362


##########
datafusion/sqllogictest/test_files/joins.slt:
##########
@@ -1336,6 +1350,25 @@ physical_plan
 10)----------RepartitionExec: partitioning=RoundRobinBatch(2), 
input_partitions=1
 11)------------MemoryExec: partitions=1, partition_sizes=[1]
 
+
+# Join on struct
+query ??
+select join_t3.s3, join_t4.s4
+from join_t3
+inner join join_t4 on join_t3.s3 = join_t4.s4
+----
+{id: 2} {id: 2}

Review Comment:
   Hmm, so the query using `IS NOT DISTINCT FROM` is actually not testing 
HashJoin path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to