comphead commented on code in PR #11232:
URL: https://github.com/apache/datafusion/pull/11232#discussion_r1664385720
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -3844,6 +3851,103 @@ mod tests {
Ok(())
}
+ pub fn build_table_struct(
+ struct_name: &str,
+ a: (&str, &Vec<Option<i32>>),
Review Comment:
can we have a name more meaningful than `a`?
Would be also nice to document the tuple.
if its pub function please add the method description for the users
UPD: if its test we can ignore method comments, but I'm not sure if it needs
to be `pub`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
