jayzhan211 commented on code in PR #11247: URL: https://github.com/apache/datafusion/pull/11247#discussion_r1664927783
########## datafusion/physical-expr/src/expressions/binary.rs: ########## @@ -257,7 +257,56 @@ impl PhysicalExpr for BinaryExpr { fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> { use arrow::compute::kernels::numeric::*; + #[inline] Review Comment: I think we don't need `inline` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org