findepi opened a new issue, #11270: URL: https://github.com/apache/datafusion/issues/11270
`assert_eq!` names its parameters "left" and "right" and doesn't seem to designate which one is expected and which is actual. However, when a test is run from RustRover, the IDE is apparently opinionated and currently expects the "right" to be "the expected" (see screenshot below). Let's decide whether we as the project want to care about this. Currently, the code varies. <img width="1156" alt="image" src="https://github.com/apache/datafusion/assets/144328/989d9c55-f032-49f0-880f-4bc93f672604";> Some RustRover references - https://github.com/intellij-rust/intellij-rust/issues/3814 - https://github.com/intellij-rust/intellij-rust/pull/3848 _Originally posted by @findepi in https://github.com/apache/datafusion/pull/11256#discussion_r1664640979_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
