alamb commented on issue #11270: URL: https://github.com/apache/datafusion/issues/11270#issuecomment-2210722692
I think consistency is a good thing. I personally prefer `assert(actual, expected)` but would follow whatever convention is chosen According to the internet there appears to be no consensus across rust https://users.rust-lang.org/t/assert-eq-expected-and-actual/20304 (perhaps the `left` and `right` is a compromise between different opinions) If we want to standardize (which seems like a good thing to me) it seems like we would: 1. Get (lazy) consensus 2. Add a note to the contributors guide: https://datafusion.apache.org/contributor-guide/index.html 3. Make as much of the code consistent as possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
