jayzhan211 commented on code in PR #11256:
URL: https://github.com/apache/datafusion/pull/11256#discussion_r1666204769
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -322,10 +322,16 @@ impl ExprSchemable for Expr {
}
}
Expr::Cast(Cast { expr, .. }) => expr.nullable(input_schema),
- Expr::AggregateFunction(AggregateFunction { func_def, .. }) => {
+ Expr::AggregateFunction(AggregateFunction { func_def, args, .. })
=> {
match func_def {
+ // TODO: min/max over non-nullable input should be
recognized as non-nullable
AggregateFunctionDefinition::BuiltIn(fun) =>
fun.nullable(),
// TODO: UDF should be able to customize nullability
+ AggregateFunctionDefinition::UDF(udf)
+ if udf.name() == "count" && args.len() <= 1 =>
Review Comment:
Instead of pattern matching all the possible function name, we can add
another method in UDAFImpl, so we can customize the nullability for each
function, as least the non-null property also applied to arra_agg, min, max,
and probably more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
