jayzhan211 commented on code in PR #11256:
URL: https://github.com/apache/datafusion/pull/11256#discussion_r1667215728
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -322,10 +322,16 @@ impl ExprSchemable for Expr {
}
}
Expr::Cast(Cast { expr, .. }) => expr.nullable(input_schema),
- Expr::AggregateFunction(AggregateFunction { func_def, .. }) => {
+ Expr::AggregateFunction(AggregateFunction { func_def, args, .. })
=> {
match func_def {
+ // TODO: min/max over non-nullable input should be
recognized as non-nullable
AggregateFunctionDefinition::BuiltIn(fun) =>
fun.nullable(),
// TODO: UDF should be able to customize nullability
+ AggregateFunctionDefinition::UDF(udf)
+ if udf.name() == "count" && args.len() <= 1 =>
Review Comment:
count for multiple args are not well-supported, maybe we should return error
for this?
```
statement ok
create table t(a int, b int) as values (1, null), (null, 2), (3, null);
query I
select count(a, b) from t;
----
0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
