viirya commented on code in PR #613: URL: https://github.com/apache/datafusion-comet/pull/613#discussion_r1666304767
########## spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala: ########## @@ -158,6 +158,11 @@ class CometTPCDSQuerySuite conf.set(CometConf.COMET_EXEC_ALL_OPERATOR_ENABLED.key, "true") conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true") conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "20g") + conf.set(CometConf.COMET_SHUFFLE_ENFORCE_MODE_ENABLED.key, "true") + conf.set("spark.sql.adaptive.coalescePartitions.enabled", "true") + // Disable `CometTakeOrderedAndProjectExec` because it doesn't produce same output order + // as Spark. + conf.set("spark.comet.exec.takeOrderedAndProjectExec.disabled", "true") Review Comment: Hmm, I found that the order of returned rows are not related to the sorting columns. For example, if you sort on [a, b], there are some rows with same [a, b] so the order of these rows are irrelevant to the sorting order, i.e., either ``` |a|b|c| |0|1|1| |0|1|2| ``` or ``` |a|b|c| |0|1|2| |0|1|1| ``` are correct results for sorting on [a, b]. In these failed queries, Spark sort produces one and DataFusion sort produces another one. Because we compare the results as string, they are considered incorrect now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org