jcsherin commented on code in PR #11287:
URL: https://github.com/apache/datafusion/pull/11287#discussion_r1667019179
##########
datafusion/functions-aggregate/src/nth_value.rs:
##########
@@ -430,3 +428,176 @@ impl NthValueAccumulator {
Ok(())
}
}
+
+/// This is a wrapper struct to be able to correctly merge `ARRAY_AGG` data
from
Review Comment:
Beyond this point is entirely [duplicated code from
`array_agg_ordered`](https://github.com/apache/datafusion/blob/7df000a333a7d4018e1446ef900f652288b1f104/datafusion/physical-expr/src/aggregate/array_agg_ordered.rs#L387)
Can be removed once `array_agg_ordered` is also converted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
