alamb commented on code in PR #11311:
URL: https://github.com/apache/datafusion/pull/11311#discussion_r1668976073
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1297,6 +1298,32 @@ pub async fn from_substrait_rex(
outer_ref_columns,
})))
}
+ SubqueryType::SetPredicate(predicate) => {
+ match predicate.predicate_op() {
+ // exist
+ PredicateOp::Exists => {
+ let relations = &predicate.tuples;
+ let plan = from_substrait_rel(
+ ctx,
+ &relations.clone().unwrap_or_default(),
+ extensions,
+ )
+ .await?;
+ let outer_ref_columns = plan.all_out_ref_exprs();
+ Ok(Arc::new(Expr::Exists(Exists::new(
+ Subquery {
+ subquery: Arc::new(plan),
+ outer_ref_columns,
+ },
+ false,
+ ))))
+ }
+ other_type => Err(DataFusionError::Substrait(format!(
+ "unimplemented type {:?} for set predicate",
+ other_type
+ ))),
Review Comment:
in f1ae84c10
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -1297,6 +1298,32 @@ pub async fn from_substrait_rex(
outer_ref_columns,
})))
}
+ SubqueryType::SetPredicate(predicate) => {
+ match predicate.predicate_op() {
+ // exist
+ PredicateOp::Exists => {
+ let relations = &predicate.tuples;
Review Comment:
in 489b96c01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
