suremarc opened a new pull request, #11363:
URL: https://github.com/apache/datafusion/pull/11363
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #11362.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This PR fixes a regression in #10434. The previous PR implements "discovery"
of new orderings when equal conditions are added. However, this discovery
process is not carried out when filters are added.
As a result, adding equality conditions tends to leave the properties in a
normalized state, but adding constants does _not_ leave the properties in a
normalized state. Thus the order in which one constructs the properties
matters.
Since the existing test for this feature applied equal conditions _after_
adding constants, this path dependence was not caught.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
We extract out the "discovery" logic into a helper method, and we ensure it
is called not only when adding equal conditions, but also when adding
constants.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes; we modify the test to construct the equivalence properties in different
orders.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No, aside from improved physical plans in some cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
