datapythonista commented on PR #750: URL: https://github.com/apache/datafusion-python/pull/750#issuecomment-2219816929
This looks great in terms of functionality, but I personally don't think it's worth to have wrappers for every DataFusion functionality just for the types and the docs. Afaik PyO3 creates Python docstrings from the Rust documentation of the exposed objects. So things can be documented in the existing Rust functions. And as you mentioned, for types, a `.pyi` file could be used. Besides a couple of other things, this seems to be what this PR provides, and I think things will be much easier to maintain if all this duplication of code in the wrappers doesn't exist. For the renaming part `datafusion.functions.functions -> datafusion.functions`, I think the intended behavior is what I implemented in #751, and shouldn't be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
