datapythonista commented on PR #750: URL: https://github.com/apache/datafusion-python/pull/750#issuecomment-2220543813
Thanks for the detailed information @timsaucer, and for all the work with this. I'm not an expert on type hints but it's not immediately clear to me what would every approach validate in a reasonable way. By using wrappers we won't have types for objects that don't exist, which can happen in the pyi file. But other than that, feels like validations should ve mostly via mypy of the unittests, and should be the same for both approaches, no? Or am I missing something? For your 3rd point, the PR I referenced in the previous message, #751, should address all the `dir()` calls, which should return the correct members. If I'm not missing anything `help()` would be working with point 1, when the objects have docstrings. So, for me personally, I fully agree with the goals, but feels like a pyi file and documenting objects in Rust will make things simpler to maintain. I may surely be wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
