mustafasrepo commented on issue #11364:
URL: https://github.com/apache/datafusion/issues/11364#issuecomment-2220122107

   During planning there are couple of physical optimization rules which modify 
the `ExecutionPlan` (rules can be found in [the 
link](https://github.com/apache/datafusion/blob/146b679aa19c7749cc73d0c27440419d6498142b/datafusion/core/src/physical_optimizer/optimizer.rs#L78)).
   Hence, I think proper place to generate id for an `ExecutionPlan` is the end 
of all optimizations where `ExecutionPlan` is finalized (doing this during the 
conversion from logical plan to physical plan may be premature).
   
   I guess, once `ExecutionPlan` is finalized, we can generate an id for the 
plan using `TreeNode` API. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to