jonahgao commented on code in PR #11391:
URL: https://github.com/apache/datafusion/pull/11391#discussion_r1672553671
##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -138,6 +138,10 @@ impl AggregateUDFImpl for Count {
return Ok(Box::new(CountAccumulator::new()));
}
+ if acc_args.input_exprs.len() > 1 {
Review Comment:
As far as I know,
[Spark](https://spark.apache.org/docs/latest/api/sql/index.html#count) and
[MySQL](https://dev.mysql.com/doc/refman/8.4/en/aggregate-functions.html#function_count-distinct)
support this syntax, although MySQL states that this feature is not standard
SQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
