wiedld commented on code in PR #11399:
URL: https://github.com/apache/datafusion/pull/11399#discussion_r1672791309
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -893,12 +893,9 @@ async fn send_arrays_to_col_writers(
let mut next_channel = 0;
for (array, field) in rb.columns().iter().zip(schema.fields()) {
for c in compute_leaves(field, array)? {
- col_array_channels[next_channel]
- .send(c)
- .await
- .map_err(|_| {
- DataFusionError::Internal("Unable to send array to
writer!".into())
- })?;
+ // Do not surface error from closed channel.
+ let _ = col_array_channels[next_channel].send(c).await;
+
Review Comment:
The tradeoff is that we don't error early and extra messages may attempt to
be passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
