hsiang-c commented on code in PR #3328: URL: https://github.com/apache/datafusion-comet/pull/3328#discussion_r2742767072
########## pr-description.md: ########## @@ -0,0 +1,72 @@ +## Summary + +This PR introduces a SQL file-based test framework for Comet expression tests and adds 123 declarative `.sql` test files covering all Comet-supported expressions. + +### Motivation + +Expression tests in `CometExpressionSuite` were written as individual Scala test methods with significant boilerplate: creating tables, inserting data, running queries, and cleaning up — all repeated for each expression. This made tests verbose, hard to review, and inconsistent in coverage. + +### SQL File Test Framework + +Two new Scala files form the framework: + +- **`SqlFileTestParser.scala`** — Parses `.sql` test files into a structured `SqlTestFile` representation. Each file can contain: + - `-- Config: key=value` — Spark SQL configs to set for the entire file + - `-- ConfigMatrix: key=value1,value2` — Generates one test per combination of values (e.g., dictionary encoding on/off) Review Comment: IIUC, we can toggle ANSI mode by `ConfigMatrix: spark.sql.ansi.enabled=true,false`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
