Jefffrey commented on PR #20070: URL: https://github.com/apache/datafusion/pull/20070#issuecomment-3821819242
If we decide to go this route, there is still some followup work: - Improve display of coercible API (e.g. the candidate functions of `log` isn't very user friendly) - Look into cleaning up error messages from [`type_coercion/functions.rs`](https://github.com/apache/datafusion/blob/f997169b2763508db55a62a7ade17d42e593cf50/datafusion/expr/src/type_coercion/functions.rs) given we strip away most of them (all except user defined) for simplicity - Look into making array signatures consistent For example this is how array function errors look like: ```sql > select array_extract(1,2,3); Error during planning: Failed to coerce function call 'array_element(Int64, Int64, Int64)'. You might need to add explicit type casts. Candidate functions: array_element(array, index) ``` - Ideally we'd show specific types instead of just `index`; though this is more about ensuring all the signatures have a consistent way of displaying themselves -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
