etk18 commented on code in PR #20064:
URL: https://github.com/apache/datafusion/pull/20064#discussion_r2744641551
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -161,7 +164,7 @@ where
views: Vec::new(),
in_progress: Vec::new(),
completed: Vec::new(),
- nulls: Vec::new(),
+ nulls: BooleanBufferBuilder::new(0),
Review Comment:
Thanks for the feedback!
I’ve updated the implementation to use NullBufferBuilder directly and now
write validity bits at insertion time using append_null() / append_non_null(),
avoiding the extra .finish() + .not() pass.
Let me know if this looks better 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
