simicd commented on PR #750: URL: https://github.com/apache/datafusion-python/pull/750#issuecomment-2223373598
First of all, thanks a lot for putting in all the work and drafting this PR @timsaucer!! I installed the package you mentioned @kylebarron to see how it behaves in an IDE. As python dev I'm particularly keen on having docstrings & examples being available when I hover over a function. Unfortunately VS Code doesn't show any docstrings with the Rust docs + .pyi approach (not sure if I need to configure anything special, below screenshots for the out-of-the-box behavior for both arro3 and polars after running pip install). So if that's indicative I'd much rather prefer the Python wrapper approach. Having documentation visible directly in VS Code was one of the big reasons that drove me to polars a while back when I was evaluating different libraries. **Example**: E.g. Rust + .pyi files does not seem to provide any documentation in VS Code (this is also the case for the pyarrow library):  Polars for instance with its wrapper approach does this:  <details> <summary>Code sample</summary> ```python # Define pyarrow array import pyarrow as pa pa_array = pa.array([1, 2, 3, 4, 5]) # Use pyarrow array in arro3 from arro3.core import Array as Array3 a3_array = Array3.from_arrow(pa_array) print(a3_array) # Use pyarrow array in polars import polars as pl df = pl.from_arrow(pa_array) print(df) ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
