timsaucer commented on code in PR #1337:
URL:
https://github.com/apache/datafusion-python/pull/1337#discussion_r2754140828
##########
src/catalog.rs:
##########
@@ -146,16 +143,22 @@ impl PyCatalog {
#[pymethods]
impl PySchema {
#[new]
- fn new(schema_provider: Py<PyAny>) -> Self {
- let schema_provider =
+ pub fn new(
Review Comment:
I *think* PyO3 still exposes these even if they aren't pub methods, but it
feels like it is better practice to have the visibility match what we expect
users to interact with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
