Dandandan commented on issue #20078: URL: https://github.com/apache/datafusion/issues/20078#issuecomment-3835828885
> It’s really exciting to see you two working on this. I’m sure you’re going to make it much better. Sorry for writing an inefficient first version of this. When clarifying question: is the direction we’re heading in to remove support for recursive simplification to improve the overhead, or are we going to get a more efficient version of the recursive implementation working? I guess the second one (more efficient version of the same functionality). As far as I can see there is now a double level of recursion leading to O(n^2) runtime (which is amplified as it also does it for every thread and has some other inefficiencies). Perhaps it makes sense to implement the changes 1 by 1 to minimize the breakage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
