Dandandan commented on PR #19761: URL: https://github.com/apache/datafusion/pull/19761#issuecomment-3842297964
Looking a bit more in the history of changes in join filter pushdown and checking some benchmark results, I am a bit concerned that we might have introduced a few regressions here and there without really noticing, that changes like these might "hide" For example, https://github.com/apache/datafusion/pull/17452 introduced waiting for all partitions to finish before starting right side evaluation, which it seems was not benchmarked on tpch/tpcds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
