mvzink commented on code in PR #2172:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2172#discussion_r2766466843
##########
src/parser/mod.rs:
##########
@@ -14032,6 +14050,79 @@ impl<'a> Parser<'a> {
})
}
+ /// Parses SELECT modifiers and DISTINCT/ALL in any order. Allows
HIGH_PRIORITY, STRAIGHT_JOIN,
+ /// SQL_SMALL_RESULT, SQL_BIG_RESULT, SQL_BUFFER_RESULT, SQL_NO_CACHE,
SQL_CALC_FOUND_ROWS and
+ /// DISTINCT/DISTINCTROW/ALL to appear in any order.
+ fn parse_select_modifiers(
+ &mut self,
+ ) -> Result<(SelectModifiers, Option<Distinct>), ParserError> {
+ let mut modifiers = SelectModifiers::default();
+ let mut distinct: Option<Distinct> = None;
+ let mut has_all = false;
Review Comment:
lmk what you think. I also reworked it a bit so that `DISTINCTROW` aliasing
only happens here and not in the main `parse_all_or_distinct` which I believe
addresses your other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
