andygrove commented on PR #3399: URL: https://github.com/apache/datafusion-comet/pull/3399#issuecomment-3853599159
> So `auto` == `native_iceberg_compat` IIUC Will this cause to slip some bugs in the future? Correct, `auto` is currently the same as `native_iceberg_compat`. The main change with this PR is that we no longer test with `native_datafusion`, so it is possible that we could introduce changes that mean we fall back to Spark for some operator when `native_datafusion` is enabled and not notice that. However, the plan is for `auto` mode to eventually choose between `native_datafusion` and `native_iceberg_compat`, so we would catch any regressions once this happens. Note that the worst case scenario here is not missing any kind of correctness issue. This test suite does not run any queries. It just checks that the plan is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
